Automated Resyntax fixes #724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-lambda` The lambda can be removed from the failure result in this `hash-ref` expression.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
This method chain made of nested `send` expressions can be written more clearly as a `send+` expression.
This `if`-`else` chain can be converted to a `cond` expression.
rfindler
reviewed
Mar 2, 2025
rfindler
reviewed
Mar 2, 2025
rfindler
reviewed
Mar 2, 2025
Member
|
Otherwise, looks good to me. |
sorawee
added a commit
to sorawee/fmt
that referenced
this pull request
Mar 2, 2025
Addressing @rfindler's comment in racket/drracket#724
sorawee
added a commit
to sorawee/fmt
that referenced
this pull request
Mar 2, 2025
Addressing @rfindler's comment in racket/drracket#724
Contributor
|
@jackfirth is there a way to re-run this with the latest version of fmt? If not, would you recommend closing the PR and wait for a new PR? |
Collaborator
|
@sorawee There's no mechanism for reruns currently. I suggest just closing it and waiting for the next round. |
Contributor
|
Got it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 6 files.
let-to-definecond-let-to-cond-definesend-chain-to-send+nested-if-to-condmap-to-forhash-ref-with-constant-lambda-to-hash-ref-without-lambda